Skip to content

add clang-format #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gengjiawen merged 1 commit into from
Sep 6, 2019
Merged

add clang-format #112

gengjiawen merged 1 commit into from
Sep 6, 2019

Conversation

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Sep 4, 2019 •
edited
Loading

Fix #111

mhdawson
mhdawson approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gengjiawen gengjiawen merged commit 1989e6e into nodejs:master Sep 6, 2019
@gengjiawen gengjiawen deleted the feature/clang-format branch September 6, 2019 12:11
SurienDG added a commit to SurienDG/node-addon-examples that referenced this pull request Sep 22, 2019
@SurienDG
Merge pull request #2 from nodejs/master
e379985 
add clang-format (nodejs#112)
@kraenhansen
Copy link
Contributor

kraenhansen commented Jan 31, 2026

I suggest moving the dependency on clang-format to dev-dependencies: #616

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gabrielschulhof gabrielschulhof gabrielschulhof approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add clang-format to this repo ?

4 participants

@gengjiawen @kraenhansen @gabrielschulhof @mhdawson